Made class public for use with modules. Using swift style optional pr…#23
Open
fraserscottmorrison wants to merge 1 commit intojimmyjose-dev:masterfrom
Open
Made class public for use with modules. Using swift style optional pr…#23fraserscottmorrison wants to merge 1 commit intojimmyjose-dev:masterfrom
fraserscottmorrison wants to merge 1 commit intojimmyjose-dev:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My project uses CocoaPods with uses_frameworks! which puts each pod into a module. To access your module I can to make a bunch of things public as the default access modifier is 'internal'.
I also removed the @objc for the optional protocol methods and implemented equivalent in Swift